Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Cleanup Prototype #30

Closed
rtisma opened this issue Nov 26, 2020 · 2 comments
Closed

Refactor and Cleanup Prototype #30

rtisma opened this issue Nov 26, 2020 · 2 comments
Assignees
@rtisma
Labels
canarie SP:3
Milestone
Canarie Sprint 13

Comments

@rtisma
Copy link
Contributor

rtisma commented Nov 26, 2020 •
edited by b-f-chan
Loading

The prototype that simply asks questions and deploy ego needs some refactoring and cleanup. This includes

  • logging
  • fix maven warnings/lint
  • proper terminal printing and abstraction
  • fix package organization
  • refactor classes to follow proper SOLID principles. Right now they are kinda POCs, just to get something working.
  • change Spec to Config, and "config Spec" to "build config"

This will lay the foundation for other tickets to follow, as alot of files and variables need to be renamed and moved around.

NOTE: Include testing here
@rtisma rtisma added the canarie label Nov 26, 2020
@rtisma rtisma added this to the [FUTURE] Canarie Sprint 11 milestone Nov 26, 2020
@rtisma rtisma self-assigned this Nov 26, 2020
@b-f-chan
Copy link
Contributor

Note: Rename spec to config!

@b-f-chan b-f-chan added the SP:3 label Nov 26, 2020
@b-f-chan
Copy link
Contributor

b-f-chan commented Jan 5, 2021 •
edited
Loading

Discussed with @rtisma - Linting not complete but it is just 1 warning - Can treat as separate ticket later (see #36) to fix warnings/linting

PR review should be done as each component completes - Discuss with @rtisma when he returns

@rtisma rtisma mentioned this issue Jan 11, 2021
Merged
@rtisma rtisma closed this as completed Jan 15, 2021
@rtisma rtisma reopened this Jan 15, 2021
@rtisma rtisma closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtisma rtisma

Labels
canarie SP:3
Projects
None yet
Milestone
Canarie Sprint 13
Development

No branches or pull requests
2 participants
@rtisma @b-f-chan