Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add/remove service calls #204

Open
anncatton opened this issue May 5, 2022 · 0 comments
Open

Refactor add/remove service calls #204

anncatton opened this issue May 5, 2022 · 0 comments
Assignees

Comments

@anncatton
Copy link
Contributor

Some of these services calls are not using the correct api route when adding/removing child entities from their parents. This is resulting in multiple api calls being made.
For example: removing 2 users from a group will make two requests, one for each user, using the users/{id}/groups/{id} DELETE endpoint instead of one call to the groups/{id}/users/{ids} DELETE endpoint.

The Ego api allows for multiple ids to be sent in these types of requests. Some investigation may be required as to why this was implemented this way on the ui side. If it was due to how the code was originally structured, hopefully this can remedied in the refactoring done in #199, #200, and #201. This issue should likely be fixed as an enhancement once this other work is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant