Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Invalid quota entry is not being cleared #100

Open
phil-davis opened this issue Nov 13, 2018 · 2 comments
Open

Invalid quota entry is not being cleared #100

phil-davis opened this issue Nov 13, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Nov 13, 2018

  1. Go to the Users page
  2. Select Other... from the Quota dropdown for a user
  3. Enter an invalid value, like -1KB
Invalid quota value "-1KB"

is displayed - good

But the displayed quota for the user shows the invalid value -1KB - problem

Refresh the page, and the quota of the user is shown correctly as the previous value.

This is causing the webUI acceptance tests "Scenario Outline: change quota to an invalid value" in tests/acceptance/features/webUIManageQuota/manageUserQuota.feature to always fail.

https://drone.owncloud.com/owncloud/user_management/334/48

  Scenario Outline: change quota to an invalid value                                                          # /var/www/owncloud/apps/user_management/tests/acceptance/features/webUIManageQuota/manageUserQuota.feature:37
    When the administrator changes the quota of user "user1" to "<wished_quota>" using the webUI              # WebUIUsersContext::theAdministratorSetsTheQuotaOfUserUsingTheWebUI()
    Then a notification should be displayed on the webUI with the text 'Invalid quota value "<wished_quota>"' # WebUIGeneralContext::aNotificationShouldBeDisplayedOnTheWebUIWithTheText()
    And the quota of user "user1" should be set to "Default" on the webUI                                     # WebUIUsersContext::quotaOfUserShouldBeSetToOnTheWebUI()

    Examples:
      | wished_quota |
      | stupidtext   |
        Users quota is set to "stupidtext" but expected "Default"
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'Default'
        +'stupidtext'
SCENARIO RESULT: (fail)
      | 34,54GB      |
        Users quota is set to "34,54GB" but expected "Default"
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'Default'
        +'34,54GB'
@phil-davis phil-davis added the bug Something isn't working label Nov 13, 2018
@phil-davis
Copy link
Contributor Author

This problem does not happen in core stable10 (where the user management code is still included in core)

@phil-davis
Copy link
Contributor Author

I do not see any code changes here in the user_management app that look suspicious.

Maybe there has been some JS or other dependency update in this app, or in core master that caused this behavior change?

@DeepDiver1975 @PVince81 ???

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant