Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxc_language_server adds the same command line parameters as oxlint and supports oxlintrc.json. #7202

Open
suxiaoshao opened this issue Nov 8, 2024 · 3 comments
Labels
C-enhancement Category - New feature or request

Comments

@suxiaoshao
Copy link

Are the command line parameters for oxc_language_server consistent with those of oxlint? Adding ‘–jsx-a11y-plugin’ doesn’t seem to work, and I can’t configure plugins in oxlintrc.json.

@suxiaoshao suxiaoshao added the C-enhancement Category - New feature or request label Nov 8, 2024
@suxiaoshao suxiaoshao changed the title oxc_language_server 添加和oxlint 一样的命令行参数,并且支持oxlintrc.json。 Oxc_language_server adds the same command line parameters as oxlint and supports oxlintrc.json. Nov 8, 2024
@pumano
Copy link
Contributor

pumano commented Nov 9, 2024

I think it's not consistent, but looks like it should be consistent (as much as possible). Some details at #7118

@nrayburn-tech
Copy link
Contributor

I’m not sure about CLI args for the language server. I don’t know if that’s standard for language servers, so I’d like to know that.

Enabling/disabling plugins with the language server somehow is definitely a requirement in my opinion.
This should be doable with oxlint json config files. I’m not sure if this is already setup or not.

@Sysix
Copy link
Contributor

Sysix commented Nov 20, 2024

I’m not sure about CLI args for the language server. I don’t know if that’s standard for language servers, so I’d like to know that.

You can configure them ans Config Properties like lint.run.
But this feels really hacky. I did not find a similar setting in eslint vscode-client

@suxiaoshao to your original Problem:
The newest oxlint version disables plugins via the config file. See here how it works: #6896 (comment)

The language server will react automatically to it.
Feel free to test it with the latest oxlint version and oxc vscode-extension.

You need to set your config with in settings.json or else it defaults to .eslintrc: { "oxc.configPath": "oxlint.json" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants