New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getenv from dal/dpdk/dal_init.c #110

Open

fruffy opened this issue Oct 27, 2023 · 0 comments

fruffy commented Oct 27, 2023

The P4 DPDK target tries to get the SDE install environment via an environment variable:

p4-dpdk-target/src/pipe_mgr/shared/dal/dpdk/dal_init.c

Line 107 in ea8ed80

install_dir = getenv("SDE_INSTALL");

This seems like it might easily lead to user errors or bugs. Is it possible to replace this call with a checked command line parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment