Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDK: Use generic CPU instructions and skip AVX512 #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DPDK: Use generic CPU instructions and skip AVX512 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/lld/dpdk/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
all:
$(shell ./apply_patch.sh > /dev/null 2>&1)
stat dpdk_src/build > /dev/null 2>&1 || \
(cd dpdk_src && meson -Dprefix=$(prefix) build && \
cd build && ninja -j48 && ninja install)
(cd dpdk_src && meson -Dcpu_instruction_set=generic -Dprefix=$(prefix) build && \
Copy link
Contributor

@vsureshkumarp vsureshkumarp Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes apply for all the builds including real hardware. I feel it is better to introduce another build option and utilize it specially for VirtualBox builds instead of making it generic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some guidance on how we might do that? I would appreciate any help to either take over this PR or guide me here. We'll need to expose this up to the IPDK level as well (e.g. P4-OVS) so it's configurable from that build level.

cd build && sed -e 's/RTE_CPUFLAG_AVX512BW\,//' -i rte_build_config.h && \
sed -e 's/RTE_CPUFLAG_AVX512CD\,//' -i rte_build_config.h && \
sed -e 's/RTE_CPUFLAG_AVX512DQ\,//' -i rte_build_config.h && \
sed -e 's/RTE_CPUFLAG_AVX512F\,//' -i rte_build_config.h && \
sed -e 's/RTE_CPUFLAG_AVX512VL\,//' -i rte_build_config.h && \
ninja -j48 && ninja install)
$(MAKE) -C infra install_dir=$(prefix)
cp infra/build/dpdk_infra.so $(libdir)/libdpdk_infra.so
install:
Expand Down