Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate() in json_generator.h and unpack_json should be implemented by the class/file that uses it. #5064

Open
fruffy opened this issue Dec 13, 2024 · 0 comments
Open

generate() in json_generator.h and unpack_json should be implemented by the class/file that uses it. #5064

fruffy opened this issue Dec 13, 2024 · 0 comments
Assignees
@fruffy
Labels
enhancement This topic discusses an improvement to existing compiler code.

Comments

@fruffy
Copy link
Collaborator

fruffy commented Dec 13, 2024

Instead of defining all these functions in the top-level headers we should distribute them across the actual classes that implement them. This way we can get rid of the circular json<->ir dependency.
@fruffy fruffy added the enhancement This topic discusses an improvement to existing compiler code. label Dec 13, 2024
@fruffy fruffy self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruffy fruffy

Labels
enhancement This topic discusses an improvement to existing compiler code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fruffy