Fix #4969 by modifying pass LocalizeActions #4970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it prepends a "." to @name annotations of global actions, if they do not have one already. Signed-off-by: Andy Fingerhut <[email protected]>
|
@smolkaj @chrispsommers Please take a look at the description in issue #4969, and the short test program that is part of this PR, and its expected P4Info output file, especially the names of the actions involved there, and see if it looks like it is correct to you. |
Signed-off-by: Andy Fingerhut <[email protected]>
fruffy
added
the
core
jafingerhut
added
the
control-plane
|
Closing this PR in favor of #4975, which contains all of the changes of this PR, and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it prepends a "." to @name annotations of global actions, if they do not have one already.