Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: use worker pool for asynchronous tasks on Windows #657

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (2f1bf9b) to head (5f2d2a4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
connection_windows.go 55.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #657      +/-   ##
==========================================
- Coverage   78.82%   78.75%   -0.08%     
==========================================
  Files          21       21              
  Lines        2546     2551       +5     
==========================================
+ Hits         2007     2009       +2     
- Misses        420      422       +2     
- Partials      119      120       +1     
Flag Coverage Δ
unittests 78.75% <55.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit db2fad2 into dev Nov 13, 2024
34 of 36 checks passed
@panjf2000 panjf2000 deleted the windows-worker-pool branch November 13, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations OS-Windows performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant