Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple site expiry from code and database #32

Open
supermacro opened this issue Feb 16, 2020 · 1 comment
Open

Decouple site expiry from code and database #32

supermacro opened this issue Feb 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@supermacro
Copy link
Member

Context

When a admin user goes through the site registration flow, they have to prove ownership of the site within a predefined number of days.

Problem

The "predefined number of days" is currently hard-coded into the codebase.

See here:

const expiryDay = d.created_at.getDate() + 7

This means that if business requirements change, I need to submit a PR to update that hard-coded value and then deploy the change.

Desired Outcome

Figure out a way to be able to dynamically update the expiry threshold in any environment.

@supermacro supermacro added the enhancement New feature or request label Feb 16, 2020
@supermacro
Copy link
Member Author

For reference:

export const buildSite = (site: Site): SiteWithExpiry => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant