Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update numeric fields data type in storage schema before merge #1037

Conversation

nikhilsinhaparseable
Copy link
Contributor

this handles scenario where stream has existing data
and event is ingested with additional fields where
infer schema differs from storage schema

server updates the storage schema before merge with infer schema and persist to storage

this handles scenario where stream has existing data and
event is ingested with additional fields where
infer schema differs from storage schema

server updates the storage schema before merge with infer schema
and persist to storage
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12385794733

Details

  • 22 of 27 (81.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 11.691%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/event/mod.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 12371831926: 0.1%
Covered Lines: 2132
Relevant Lines: 18237

💛 - Coveralls

@nitisht
Copy link
Member

nitisht commented Dec 19, 2024

Closing for now, we'll reassess the approach we want to take for this issue

@nitisht nitisht closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants