You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think an UPSERT would work just fine in place of the DELETE and CREATE. At the time this was written UPSERT hadn't yet been added to the spec.
A word of caution however. This project still works however it is not actively maintained. As you can see the last commit was 2017, and the first commit was 9 years ago. While I'm happy to review your changes, run the test suite, and publish a new release you should exercise some caution when using the gem.
Current implementation of
update
method isDELETE
andCREATE
(ruby_route_53/lib/route53/dns_record.rb
Lines 66 to 77 in f96fab5
I suggest to change it to action
UPSERT
, which AWS describe as update of record set (see https://docs.aws.amazon.com/Route53/latest/APIReference/API_ChangeResourceRecordSets.html)This change optimize our workflow with DNS record sets.
Make this feature sense for you ? Do you prefer implement new method
upsert
instead of change currentupdate
?Thx
The text was updated successfully, but these errors were encountered: