You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The majority of the classes in this project are data containers.
Although writing unit-tests for the non-logic classes will be a lot easier, the main focus for quality should be on the Server, TokenGenerator, and WAC classes, and code under the src/Utils directory.
Other classes
Config
The files in the Config directory are mostly data objects. They are small enough that adding tests should be trivial, simply test the output of getter methods.
Entity
The clases under this directory are all just container that use traits from the vendor project.
No testing for these is needed, as tests are already provided by the upstream.
Enum
All classes un der the src/Enum directory only contain data, except for Enum/OpenId/OpenIdConnectMetadata and Enum/OAuth2/Parameter. Both extend an abstract parent. An abstract test class has alread been created, plus tests for OpenIdConnectMetadata. It should be trivial, following the example of the existing code, to also add a test for the OAuth2/Parameter class.
Factory
Classes under the Factory directory are factories. Simple input/output (call the factory with a specific input, validate a specific output is provided) tests should suffice.
Repository
The code under the Repository directory is a mix of factory and data container. Tests would be mostly similar to that of factories.
The text was updated successfully, but these errors were encountered:
Main focus
The majority of the classes in this project are data containers.
Although writing unit-tests for the non-logic classes will be a lot easier, the main focus for quality should be on the
Server
,TokenGenerator
, andWAC
classes, and code under thesrc/Utils
directory.Other classes
Config
The files in the Config directory are mostly data objects. They are small enough that adding tests should be trivial, simply test the output of getter methods.
Entity
The clases under this directory are all just container that use traits from the vendor project.
No testing for these is needed, as tests are already provided by the upstream.
Enum
All classes un der the
src/Enum
directory only contain data, except forEnum/OpenId/OpenIdConnectMetadata
andEnum/OAuth2/Parameter
. Both extend an abstract parent. An abstract test class has alread been created, plus tests for OpenIdConnectMetadata. It should be trivial, following the example of the existing code, to also add a test for the OAuth2/Parameter class.Factory
Classes under the Factory directory are factories. Simple input/output (call the factory with a specific input, validate a specific output is provided) tests should suffice.
Repository
The code under the Repository directory is a mix of factory and data container. Tests would be mostly similar to that of factories.
The text was updated successfully, but these errors were encountered: