Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we rename XService classes to XEndpoint? #19

Open
matejdro opened this issue May 3, 2021 · 1 comment
Open

Should we rename XService classes to XEndpoint? #19

matejdro opened this issue May 3, 2021 · 1 comment

Comments

@matejdro
Copy link
Contributor

matejdro commented May 3, 2021

Currently, all communication classes are named MusicService, SystemService etc., but they are not really services. They only facilitate communication between watch and phone.

I suggest that we rename those to the MusicEndpoint, SystemEndpoint etc. That way we can create MusicService in the app without naming conflicts.

@crc-32 what do you think?

@crc-32
Copy link
Member

crc-32 commented Jun 14, 2021

The original idea was to be roughly following the architecture of libpebble2 (https://github.com/pebble-dev/libpebble2/tree/master/libpebble2/services) but it might not be appropriate naming for how we want to use them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants