Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ProtoFile syntax to be specified by user #4

Open
perezd opened this issue Aug 2, 2020 · 0 comments
Open

Allow ProtoFile syntax to be specified by user #4

perezd opened this issue Aug 2, 2020 · 0 comments
Labels

Comments

@perezd
Copy link
Owner

perezd commented Aug 2, 2020

A new builder method like setSyntax should be added, and should accept an enum, perhaps:

ProtoFile.builder().setSyntax(ProtoSyntax.PROTO3)

This syntax enum should be available to the internals of the system so that spec enforcement can be done. Today, only proto2 or proto3 are valid options. The default should be proto3 if not specified given that was the default when this library/API was introduced.

@perezd perezd added the proto2 label Aug 2, 2020
@perezd perezd changed the title All ProtoFile syntax to be specified by user Allow ProtoFile syntax to be specified by user Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant