Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow importing partial datasets from the server #297

Open
atomrab opened this issue Jul 27, 2020 · 4 comments
Open

Disallow importing partial datasets from the server #297

atomrab opened this issue Jul 27, 2020 · 4 comments
Assignees
Labels

Comments

@atomrab
Copy link

atomrab commented Jul 27, 2020

I made a local collection and imported changes from the Chersonesos authority I made a month or so ago. This was the only authority I imported. I then added a new period and made some minor tweaks to the editorial note in another, and submitted the changed version as a patch.

In the patch change summary, I saw not only those changes but the deletion of all of the derived-from relations I had included in the original authority. These deletions persisted even when I added the authorities from which those periods were derived. See below (also, oddly, in that record only some of the linked narrower definitions appear as links, though they're all linked when one looks at the authority in browse or edit view).

Adding new periods to existing authorities that have derived-from relationships seems like it will be an increasingly common use-case. We don't want to lead people to accidentally erase those existing relationships.

image

@atomrab
Copy link
Author

atomrab commented Jul 27, 2020

NB: I needed the new period for something I'm working on right now, so I submitted this patch with just that period (and without the edits to the existing period editorial note). I can resubmit if you need a tester for the derived-from issue (and we can then also test the pre/post-URI validation with the new period, as a bonus).

@rybesh
Copy link
Member

rybesh commented Jul 27, 2020

@ptgolden I think this is probably a side effect of the recent fix you made to solve the inverse problem, where someone tries to submit a patch with dangling references. I think we need to check whether or not the dangling references are to a period with a permalink, and if so, allow them / don't remove them from the patch.

@rybesh rybesh added the bug label Jul 27, 2020
@rybesh
Copy link
Member

rybesh commented Jul 27, 2020

related to #267

@rybesh
Copy link
Member

rybesh commented Sep 12, 2023

I think the best way to deal with this is to disallow importing partial datasets from the server. That way we avoid the issue of people accidentally forgetting to import related authorities.

@rybesh rybesh self-assigned this Sep 12, 2023
@rybesh rybesh changed the title Complications with editing and submitting patches for authorities that have derived-from relationships Disallow importing partial datasets from the server Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants