You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I made a local collection and imported changes from the Chersonesos authority I made a month or so ago. This was the only authority I imported. I then added a new period and made some minor tweaks to the editorial note in another, and submitted the changed version as a patch.
In the patch change summary, I saw not only those changes but the deletion of all of the derived-from relations I had included in the original authority. These deletions persisted even when I added the authorities from which those periods were derived. See below (also, oddly, in that record only some of the linked narrower definitions appear as links, though they're all linked when one looks at the authority in browse or edit view).
Adding new periods to existing authorities that have derived-from relationships seems like it will be an increasingly common use-case. We don't want to lead people to accidentally erase those existing relationships.
The text was updated successfully, but these errors were encountered:
NB: I needed the new period for something I'm working on right now, so I submitted this patch with just that period (and without the edits to the existing period editorial note). I can resubmit if you need a tester for the derived-from issue (and we can then also test the pre/post-URI validation with the new period, as a bonus).
@ptgolden I think this is probably a side effect of the recent fix you made to solve the inverse problem, where someone tries to submit a patch with dangling references. I think we need to check whether or not the dangling references are to a period with a permalink, and if so, allow them / don't remove them from the patch.
I think the best way to deal with this is to disallow importing partial datasets from the server. That way we avoid the issue of people accidentally forgetting to import related authorities.
rybesh
changed the title
Complications with editing and submitting patches for authorities that have derived-from relationships
Disallow importing partial datasets from the server
Sep 12, 2023
I made a local collection and imported changes from the Chersonesos authority I made a month or so ago. This was the only authority I imported. I then added a new period and made some minor tweaks to the editorial note in another, and submitted the changed version as a patch.
In the patch change summary, I saw not only those changes but the deletion of all of the derived-from relations I had included in the original authority. These deletions persisted even when I added the authorities from which those periods were derived. See below (also, oddly, in that record only some of the linked narrower definitions appear as links, though they're all linked when one looks at the authority in browse or edit view).
Adding new periods to existing authorities that have derived-from relationships seems like it will be an increasingly common use-case. We don't want to lead people to accidentally erase those existing relationships.
The text was updated successfully, but these errors were encountered: