Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCSS shadows are camera dependent #360

Open
vorg opened this issue Feb 9, 2024 · 0 comments
Open

PCSS shadows are camera dependent #360

vorg opened this issue Feb 9, 2024 · 0 comments
Labels
high scope/pbr type/fix A bug fix
Milestone
4.0.0

Comments

@vorg
Copy link
Member

vorg commented Feb 9, 2024

As you move camera shadow moves from smooth to sharp to inside out / broken / cropped both in Nodes and pex-renderer/examples/lights.

shadowQuality: 5
directionalLight.radius = 1000

Screenshot 2024-02-09 at 15 43 20
@dmnsgn dmnsgn added this to the 4.0.0 milestone May 16, 2024
dmnsgn added a commit to pex-gl/pex-shaders that referenced this issue May 28, 2024
@dmnsgn
fix: correct DepthGradient for PCSS
97ed2ae 
- division was missing parenthesis
- use depth value directly in blocker search and bump search samples
- use simplex texture2D/CubeCompare instead of lerp and bump pcf samples

- pex-gl/pex-renderer#360
@dmnsgn dmnsgn added the high label May 30, 2024
@github-project-automation github-project-automation bot moved this to To do in 4.0.0 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high scope/pbr type/fix A bug fix
Projects
4.0.0
Status: To do
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@vorg @dmnsgn