Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

When built using the latest version of devkitarm and ctrulib, opening the app with no wifi connection will cause a data abort. #8

Open
hacker1024 opened this issue Jan 28, 2018 · 2 comments
Open

When built using the latest version of devkitarm and ctrulib, opening the app with no wifi connection will cause a data abort. #8

hacker1024 opened this issue Jan 28, 2018 · 2 comments
Labels
bug

Comments

@hacker1024
Copy link

hacker1024 commented Jan 28, 2018 •
edited
Loading

I see "Did you enable wifi?" for a split second before.
EDIT: Removing the goto failure line stops the data abort, and then ctroller just waits until a wifi connection is established. Why goto failure in the first place?
@hacker1024 hacker1024 mentioned this issue Jan 28, 2018
Open
@hacker1024
Copy link
Author

I've fixed this: pull request #9

@hacker1024 hacker1024 mentioned this issue Jan 28, 2018
Open
@phijor phijor added the bug label Jan 28, 2018
@phijor
Copy link
Owner

phijor commented Feb 6, 2018 •
edited
Loading

Hey, sorry for taking so long to respond to this. I was kind of busy.

I appreciate the pull request, but I'm not really a fan of ignoring any error values. But you are right that waiting for wifi might be good behavior.

ed5665f fixes crashing on launch (for me at leas), can you verify?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phijor @hacker1024