Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add curly interpolation, but respect phx-no-curly-interpolation #30

Closed
wants to merge 1 commit into from

Conversation

SteffenDE
Copy link

Relates to #28.
Fixes #29.

@SteffenDE
Copy link
Author

image

@SteffenDE
Copy link
Author

There's still a flaw where it is not detected as no curly when the phx-no-curly-interpolation is on another line.

@SteffenDE SteffenDE marked this pull request as draft December 8, 2024 17:30
@SteffenDE
Copy link
Author

I looked into this and came to the conclusion that it's not possible to reasonably do this, as Textmate grammars cannot have multiline begin patterns. Therefore, as soon as someone does

<p
  phx-no-curly-interpolation
  class=""
  ...
>...</p>

we would not be able to reasonable detect this.

Closing in favor of #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Update syntax highlighting for LiveView 1.0.0 release
1 participant