Notification area in the Center is too small, when one of the messages is too long

[dmigis]

There is a problem: The area in which notifications are displayed is arbitrarily clipped, if there at least one of the notifications is too long. Using deadd-notification-center-bin from AUR. Same with deadd-notification-center

[MyriaCore]

I experienced this when implementing #78. I believe @phuhl did too.

[phuhl]

yeah, have that, too

[phuhl]

it is a little annoying to deal with because it is a fight against gtk but it is an annoying bug, too.

[MyriaCore]

See #78 (comment):

I think, splitting this into two PRs is a good idea! Btw, I also know now, why your buttons don't appear. It is not, because they are hidden, but because of the rather hacky way that I use to set the notification size. Look at line 176 of NotificationPopup.hs. It returns the height of the notification by receiving the preferred height for a set width. I do it like that, because at the point of writing, gtk did not have a feature to set the width directly, only the height. What I did is the following: Get the "preferred height" at the desired width. Set the height to the preferred height and hope, that the width is correct then. That is also the reason why the notification center bugs arround in #40 I think.

Anyways, back to your buttons. I set the height of the notification by setting it on the label in the background (that is the only reason why it is there). Since you changed the glade's layout, the buttons are not taken into account when calculating the height so they stick out to the bottom of the notification. To prove it: return (a + 100) and find that your buttons are totally visible.

The getHeight function is what's talked about. It's called in showNotificationWindow and updateNoti':

linux_notification_center/src/NotificationCenter/Notifications/NotificationPopup.hs

Lines 83 to 86 in 499c75b

	let dispNoti = set dNotiGetHeight
	(getHeight (view dContainer dispNotiWithoutHeight) config)
	dispNotiWithoutHeight
	lblBody = (flip view) dispNoti $ dLabelBody

linux_notification_center/src/NotificationCenter/Notifications/NotificationPopup.hs

Lines 157 to 158 in 499c75b

	height <- getHeight (view dContainer dNoti) config
	widgetSetSizeRequest (_dLabelBG dNoti) (-1) height

Here is the definition for getHeight:

linux_notification_center/src/NotificationCenter/Notifications/NotificationPopup.hs

Lines 173 to 176 in 499c75b

	getHeight widget config = do
	(a, b) <- widgetGetPreferredHeightForWidth widget
	$ fromIntegral $ configWidthNoti config
	return a

[MyriaCore]

This bug appears quite frequently for me in the master branch of my fork. Not rly sure when I'll have any time to implement a fix, but I'd love any insight on how to fix this.

Do we even need to be setting the height directly? Shouldn't GTK just scale the window as needed when elements need more space? Maybe we set the width with widgetSetSizeRequest, since it's a config var, but idk if we need to set the height.

[MyriaCore]

Looking into things more, it seems like this dLabelBG thing is a dummy label that's only used to size itself up so the size can propogate to the parent. I'm almost certain there's a better way to do this. Why can't we directly manipulate the size of the widget container itself?

[phuhl]

Afaik you can only set the height, but not the width with GTK. Why I used the label, I don't know anymore, but surely there was a reason

[MyriaCore]

I don't doubt that you had your reasons, it just feels like widgetSetSizeRequest should still be able to set width. I mean, the docs say it does. Maybe you ran into a bug when doing that?

Even so, this code shouldn't rly be running for the notification center, right? Like the code in NotificationPopup is only for popups I thought. In fact, wouldn't NotificationInCenter.showNotification be called instead, via NotificationCenter.updateNotis?

I'm sure this was the source of the button bug (which would ideally be fixed in #77), but maybe the source of this bug is something else?

[phuhl]

Yeah, that particular label should not play any role in this. The notifications in center don't even have that lable iirc...