-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disk size gets trimmed to default size on init method #240
Comments
One suggestion would be, Keeping byteLimit as initialising parameter for PINCache. |
@rajeshs73 if you set the byteLimit immediately after initialization this shouldn't be an issue in practice (though I agree we should allow setting this on init) because the trimming doesn't happen until the file state is known which takes a while. Have you tried setting the byteLimit immediately after initializing the disk? |
@garrettmoon I did set the byteLimit soon after the initialization. It falls back to default size on app open (mostly 6 out of 10 times) |
Did you solve this problem @rajeshs73? |
No. I haven't. |
Any chance we could fix this? |
@rajeshs73 are you initialising PINCache and setting its configuration from the main thread? |
this is fixed by #312, which as on |
If my disk size is more than default size, it gets trimmed to default size on initialising PINCache.
Due to that, my images are downloading again and again and getting stored in disk.
I have set the byteLimit to 100MB too.
The text was updated successfully, but these errors were encountered: