Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all updates to smogon/usage-stats are reflected in @pkmn/stats #13

Closed
scheibo opened this issue Aug 27, 2024 · 2 comments
Closed
Assignees
Labels
stats Issue related to @pkmn/stats

Comments

@scheibo
Copy link
Contributor

scheibo commented Aug 27, 2024

@pkmn/stats is based on version of https://github.com/Antar1011/Smogon-Usage-Stats that was used by Smogon around ~2020, though which is out of sync with https://github.com/smogon/usage-stats. This issue will remain open until #10 is closed and will track changes made to stay in sync (modulo work such as #12 which is already a known feature gap), include for any changes made to the upstream repo after this point.

@scheibo scheibo added the stats Issue related to @pkmn/stats label Aug 27, 2024
@scheibo scheibo self-assigned this Aug 27, 2024
@scheibo
Copy link
Contributor Author

scheibo commented Aug 27, 2024

  1. RunMonthly.sh seems to replace Catchup.sh, but Implement simple logs processing loop that is suitable for processing large amounts of usage stats #11 is going to basically manage RunMonthly.sh's job anyway
  2. MonotypeAnalysis.sh now uses 5 processes instead of 3 but otherwise has just been updated from gen7mono -> gen9mono
  3. MonthlyAnalysis.sh has had its tiers updated, upped to 5 processes and split out the 1695 and other stats such that they can all process in parallel. Once again, Implement simple logs processing loop that is suitable for processing large amounts of usage stats #11 should simply look at the upstream versions of what its trying to replace as it will cover this
  4. RunPartial.sh/PartialAnalysis.sh mostly just seem to exist to allow for running over a small range of days (eg. to quickly figure out how a meta has progressed or for DLC etc). this seems like something also easily covered by Implement simple logs processing loop that is suitable for processing large amounts of usage stats #11 - really, stats should get processed and compressed daily and then running reporting ranges can just some up the various days
  5. All the TierUpdate*.py files should be covered by Refactor tier update reports #12
  6. common.py:
  7. TA.py: basically still unchanged (maybe indicates no one cares and it should be deleted...), StatCounter.py is also unchanged
  8. batchLogReader.py:
  9. batchMovesetCounter.py

@scheibo
Copy link
Contributor Author

scheibo commented Sep 20, 2024

Closing this out because everuthing should be tracked elsewhere. Can reopen if upstream makes changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stats Issue related to @pkmn/stats
Development

No branches or pull requests

1 participant