Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path shown in item selection widget is stripped based on navigation root path #125

Open
erral opened this issue Apr 12, 2017 · 4 comments
Open

Comments

@erral
Copy link
Member

erral commented Apr 12, 2017

Why do we cut the path of the item based on the nearest INavigationRoot?

https://github.com/plone/plone.app.content/blob/master/plone/app/content/browser/vocabulary.py#L119

https://github.com/plone/plone.app.content/blob/master/plone/app/content/browser/vocabulary.py#L205

https://github.com/plone/plone.app.content/blob/master/plone/app/content/browser/vocabulary.py#L227

With this the path shown when configuring a collection or a collection portlet, or selecting a content-item through TinyMCE gets cut, and only the part of the path from the navigation root on is shown.

For instance, here, I am configuring a collection portlet in a multilingual site (/en, /es and /eu are navigation root objects).

2017-04-12 09-35-49-ko-pantaila-argazkia

The widgets shows the contents from all navigation roots, but the shown paths are missing the initial /eu, /es, /en.

I patched the get_base_path method to strip only the part regarding the Plone site root's id, and it shows like this:

2017-04-12 09-38-39-ko-pantaila-argazkia

Is the first one an intended behavior? I find it confusing...

Any idea on this? @Gagaro

@Gagaro
Copy link
Member

Gagaro commented Apr 12, 2017

Because it would show the portal path too (/plone/eu/[...]). By default, you should only see objects in the navigation root. I did another commit in mockup to be able to change that (plone/mockup@4080f5f).

Did you change anything to have all the objects from the portal root instead of the nav one ?

@erral
Copy link
Member Author

erral commented Apr 12, 2017

No, I have no changes regarding that, I see all objects

@Gagaro
Copy link
Member

Gagaro commented Apr 12, 2017

Are you on 5.0 or 5.1 ? I think it was changed back to navigation root on 5.1.

@erral
Copy link
Member Author

erral commented Apr 12, 2017

Could be, I am on 5.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants