Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plugin hard dependency from PermissionAttachment #6543

Open
dktapps opened this issue Nov 29, 2024 · 0 comments
Open

Remove Plugin hard dependency from PermissionAttachment #6543

dktapps opened this issue Nov 29, 2024 · 0 comments
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Nov 29, 2024

Problem description

This dependency makes it inconvenient to create PermissionAttachments within the core.

This would be useful for temporary permission overrides internally, e.g. gameplay permission overrides for #5544 that disappear when the player's gamemode is changed.

Proposed solution

Make the Plugin parameter optional, or get rid of it entirely - depends whether it's actually useful for anything or not.

Alternative solutions that don't require API changes

@dktapps dktapps added Category: API Related to the plugin API Category: Core Related to internal functionality BC break Breaks API compatibility Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

1 participant