Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/swodlr UI final fixes - bug fixed before version 1.0 release #91

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

jbyrne6
Copy link
Contributor

@jbyrne6 jbyrne6 commented Feb 29, 2024

Fixes

  • There are not enough refreshes while performing spatial search which results in url state bugs
  • Too many alerts when doing spatial search
  • Duplicate Products (granules) display when generating products, and duplicates fails w/ 'ERROR' status (when using the map spatial search option (BBOX))
  • When generating products using map spatial search option (BBOX), various warnings display while scenes are being retrieved / added ("The scenes entered are not available." "Some scenes entered are not available.")
  • The 'About SWODLR' hyperlink on main page (footer) non-functional (note: UI main page prior to Earthdata Login)
  • Warning displays when navigating to or refreshing the 'My Data' page in UI: "No product have been generated. Go to the Products Customization page to generate products
  • User was not able to successfully Add Scene when using Cycle (001), but was able to add scene as expected using Cycle (1). Entering a 3 digit cycle seems to be an issue (E.g., try adding scene for cycle:001, pass:414, scene23 or cycle:007, pass:072, scene13-14). note: also not able to successfully Add Scene using 3-digit Scene (022 or 023), but was able to add scene as expected using Scene (23 or 22).
  • 'Configure Products' should not be an option after adding scenes in UI, as this configuration already occurred via Select Scene 'Configure Options' (top of the Customization page in UI)
  • Customization page in UI - user unable to delete Added Scenes. When refreshing the page after added scenes removed/deleted, the deleted scenes re-appear in SWODLR UI FIX: remove url param when deleting from table
  • Customization page in UI - Map sizing issues. The size of map should remain in place. The Map in UI should not randomly re-size (e.g., after sizing, and navigating through menus, and back to customization page w/ map or when refreshing the page)
  • 'My Data' page in UI: (user only can only view / display 10 rows of generated data in UI) Generated Products Data do not retain in UI (Should pagination or page numbers be Implemented ?)
  • 'Configure Options / Products' page - advanced options 'Scenes to Customize' - User unable to toggle or select all of the row options for UTM Zone Adjust or MGRS Band Adjust
  • Tutorial modal does now start when you click the Tutorial navbar button when on certain pages.
  • The 'Back' function does not work as expected for tutorial pages (12/18), (16/18). The tutorial crashes/exits. For tutorial page (17/18), try the 'Back' and then 'Next' to see the issue (blank screen displays if navigating back to Customization/About tabs after selecting 'Next; If user selects the MyData page after selecting 'Next', the tutorial window re-appears w/ tutorial page (18/18)))
  • speed up spatial search load time
  • tutorial back button crashes site
  • Can’t change adjust of spatial search granules (SIT) (I am not able to reproduce in SIT. It is working in SIT for me.)
  • About page in UI: the 'original algorithm' hyperlink triggers an Invalid Key error (waiting on email back from Alexander Corben with the working link)
  • 10 scene granule limit
  • Spinner running too long
  • added version numbers to footer and about page
  • Map stays at same location after refresh (not including search polygons)
  • Can re-run tutorial successfully now after fully completing first tutorial
  • Outside of the map bounds it says "map data not yet available"

David C.'s comments: 02/20/2024

SWODLR (SIT/UAT) UIs:
SWODLR UI: 1.0.0-rc.8
SWODLR API: 0.0.1-alpha48
note:
Some of the listed issues are also documented in related UI Bug Fixes ticket:
#72

  • There are not enough refreshes while performing spatial search which results in url state bugs
    OK- This issue appears to be currently resolved

  • Too many alerts when doing spatial search
    OK- This issue appears to be currently resolved

  • Duplicate Products (granules) display when generating products, and duplicates fails w/ 'ERROR' status (when using the map spatial search option (BBOX))
    OK- in SWODLR UIs - Duplicate Products no longer display

  • When generating products using map spatial search option (BBOX), various warnings display while scenes are being retrieved / added ("The scenes entered are not available." "Some scenes entered are not available.")
    OK- in SWODLR UIs

  • The 'About SWODLR' hyperlink on main page (footer) non-functional (note: UI main page prior to Earthdata Login)
    OK- This issue is now resolved - the'About SWODLR' hyperlink on main page (footer) was removed accordingly (note: UI main page prior to Earthdata Login)

  • Warning displays when navigating to or refreshing the 'My Data' page in UI: "No product have been generated. Go to the Products Customization page to generate products
    Pending Fix- This Issue still exists in SWODLR SIT/UAT

  • User was not able to successfully Add Scene when using Cycle (001), but was able to add scene as expected using Cycle (1). Entering a 3 digit cycle seems to be an issue (E.g., try adding scene for cycle:001, pass:414, scene23 or cycle:007, pass:072, scene13-14). note: also not able to successfully Add Scene using 3-digit Scene (022 or 023), but was able to add scene as expected using Scene (23 or 22).
    OK- This issue appears to be currently resolved in SWODLR SIT/UAT

  • 'Configure Products' should not be an option after adding scenes in UI, as this configuration already occurred via Select Scene 'Configure Options' (top of the Customization page in UI)
    OK- This issue is resolved - the 'Configure Products' screen is no longer in the UI. User must now use the 'Configure Options' screen prior to Generating Products - resolved in SWODLR SIT/UAT

  • Customization page in UI - user unable to delete Added Scenes. When refreshing the page after added scenes removed/deleted, the deleted scenes re-appear in SWODLR UI FIX: remove url param when deleting from table
    OK- This issue appears to be currently resolved in SWODLR SIT/UAT

  • Customization page in UI - Map sizing issues. The size of map should remain in place. The Map in UI should not randomly re-size (e.g., after sizing, and navigating through menus, and back to customization page w/ map or when refreshing the page)
    The map seems to remain in place now after refreshing UI accordingly .
    But, note: a created Polygon (BBOX) disappears from UI. note2: the MAP in UI should be more of a rectangular shape instead of the current small, square shape

  • 'My Data' page in UI: (user only can only view / display 10 rows of generated data in UI) Generated Products Data do not retain in UI (Should pagination or page numbers be Implemented ?)
    OK- Verified that the user only can now view more than 10 rows of generated data on 'My Data' page in SWODLR SIT/UAT UI.
    NOTE: SWODLR UI still needs pagination and page numbers implemented. Table sorting and/or page limit(s) needed as well (E.g. Show 20 per page, Show 50 per page, Show 100 per page, etc) - related issues in GIThub:
    Implement My Data page filtering #70
    Implement My Data page Pagination #71

  • 'Configure Options / Products' page - advanced options 'Scenes to Customize' - User unable to toggle or select all of the row options for UTM Zone Adjust or MGRS Band Adjust
    OK - This issue appears to be currently resolved in SWODLR SIT/UAT.

  • Tutorial modal does now start when you click the Tutorial navbar button when on certain pages.
    OK- This tutorial modal bug seems to be okay at this time.

  • The 'Back' function does not work as expected for tutorial pages (12/18), (16/18). The tutorial crashes/exits. For tutorial page (17/18), try the 'Back' and then 'Next' to see the issue (blank screen displays if navigating back to Customization/About tabs after selecting 'Next; If user selects the MyData page after selecting 'Next', the tutorial window re-appears w/ tutorial page (18/18)))
    OK- This tutorial modal bug seems to be okay at this time.
    Note: still have tutorial modal issue where the tutorial goes back to the Scenes to customize page in lieu of the My Data page. Happens when back-paging from tutorial page (16/17) to (15/17)

  • speed up spatial search load time
    OK- This issue appears to be currently resolved

  • tutorial back button crashes site
    OK- back button crashes are no longer occurring
    Note: still have tutorial modal issue where the tutorial goes back to the Scenes to customize page in lieu of the My Data page. This happened when back-paging from page (16/17) to (15/17)

  • Can’t change adjust of spatial search granules (SIT) (I am not able to reproduce in SIT. It is working in SIT for me.)
    OK- This issue appears to be currently resolved

  • About page in UI: the 'original algorithm' hyperlink triggers an Invalid Key error (waiting on email back from Alexander Corben with the working link)
    OK- This issue is now resolved - the original algorithm Hyperlink no longer shows an error when selected

  • 10 scene granule limit
    OK- The 10 scene granule limit now seems to function as expected. No more than 10 rows of Added scenes can be currently accepted in UI

  • Spinner running too long
    OK- it seems like this issue is okay now, the spinner no longer takes a while to finish after scenes are added

  • added version numbers to footer and about page
    Confirmed that version information was added to the About page (and in the footer in UI).
    note: Still need to remove the 'Version History' info from the About page

  • Map stays at same location after refresh (not including search polygons)
    Confirmed that the map seems to remain in place now after refresh accordingly.
    But, note: a user created Polygon (BBOX) disappears from UI

  • Can re-run tutorial successfully now after fully completing first tutorial
    OK- This 're-run tutorial' modal issue is currently resolved

  • Outside of the map bounds it says "map data not yet available"
    OK- This issue is now resolved
    note: the MAP in UI should be more of a rectangular shape instead of the current small, square shape (e.g., when map is minimized)

@jbyrne6 jbyrne6 added the bug Something isn't working label Feb 29, 2024
@jbyrne6 jbyrne6 self-assigned this Feb 29, 2024
@jbyrne6
Copy link
Contributor Author

jbyrne6 commented Mar 1, 2024

I added in the SWOT collection cmr permissions check ticket into this PR so it is in one place to merge into the release branch. To test the SWOT collection permissions, make a dummy Earthdata Login account. Once logged in, you should not be able to perform spatial search on the map or add any scenes. You should also see a warning in yellow on the bottom left of the page.

Base automatically changed from release/1.0.0 to main March 12, 2024 08:50
@frankinspace frankinspace changed the base branch from main to release/1.0.0 March 25, 2024 21:45
@frankinspace frankinspace merged commit 7faf449 into release/1.0.0 Mar 25, 2024
6 checks passed
@frankinspace frankinspace deleted the issues/swodlr-ui-final-fixes branch March 25, 2024 21:57
@davidcolemanjpl
Copy link

davidcolemanjpl commented Mar 26, 2024

SWODLR UI (UAT): v1.0.0-rc.8 Beta
SWODLR API: v0.0.1-alpha48

Map related anomalies pending:

  • A created Polygon (BBOX) disappears from UI (e.g., when user navigates away from and back to the Customization page)
  • The MAP in UI should be more of a rectangular shape instead of the current small, square shape (e.g., when Map size is minimized)
  • Map Footprint Scenes appear to be outside of a created BBOX (see attachment):

scenes-outside-BBOX-UAT-1

cqbanh added a commit that referenced this pull request Mar 27, 2024
* /version v1.0.0-rc.1

* /version v1.0.0-rc.2

* Pull in recent changes to 1.0.0

* /version v1.0.0-rc.3

* Fix umm-t record

* /version v1.0.0-rc.4

* Fix umm-t record

* /version v1.0.0-rc.5

* Fix umm-t record

* /version v1.0.0-rc.6

* /version v1.0.0-rc.7

* issue/manual-granule-input-hotfix: fixed how ranged of scenes are processed (#86)

Co-authored-by: jbyrne <[email protected]>

* Issues/swodlr UI 72 essential UI bug fixes (#87)

* issues/swodlr-ui-72: fix cps url params bug

* issues/swodlr-ui-72

* issues/swodlr-ui-75: fixed a couple bugs

* issues/swodlr-ui-72: fixed map movement, adjust options, data page limit, etc

* issues/swodlr-ui-72: changed spatial search beginning date in range

* issues/swodlr-ui-72-essential-fixes: cleaned up comments

---------

Co-authored-by: jbyrne <[email protected]>

* /version v1.0.0-rc.8

* Deploying

* Update build.yml - OPS environment variable for release

* Update build.yml - add OPS choice

* /version 1.0.0

* Update build.yml - check for staged changes

* Deploying

* Update build.yml - checks if tag exists

* Update build.yml - check for tag on remote

* Update build.yml - replace tag if exists

* Update build.yml - trying force tag

* Update build.yml - allow release update

* Deploying

* Issues/swodlr UI final fixes - bug fixed before version 1.0 release (#91)

* issues/swodlr-ui-final-fixes: fixed spatial search speed and tutorial back fix

* issues/swodlr-ui-final-fixes: fixed spinner, 10 limit, tutorial, map on reload

* issues/swodlr-ui-final-fixes: fixed delete bug and added success alert for generation

* issues/swodlr-ui-final-fixes: made alert message for search area too large

* issues/swodlr-ui-final-fixes: changed search area too large message

* issues/swodlr-ui-final-fixes: start search polygon url param

* issues/swodlr-ui-final-fixed: removed skip from tutorial, added copy/download tooltips product url

* issues/swodlr-ui-final-fixes: added tutorial close confirmation modal

* issues/swodlr-ui-final-fixes: added cmr SWOT collection permissions check

* issues/swodlr-ui-final-fixes: made cmr permissions alert conditional

* issues/swodlr-ui-final-fixes: fixed tutorial back error and no data history tutorial error

---------

Co-authored-by: jbyrne <[email protected]>

---------

Co-authored-by: frankinspace <[email protected]>
Co-authored-by: Frank Greguska <[email protected]>
Co-authored-by: Jonathan M Smolenski <[email protected]>
Co-authored-by: jonathansmolenski <[email protected]>
Co-authored-by: Jimmy <[email protected]>
Co-authored-by: jbyrne <[email protected]>
Co-authored-by: cqbanh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants