Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention bootctl in error message if ESP isn't found #73

Open
pikrzysztof opened this issue Oct 30, 2021 · 2 comments
Open

Mention bootctl in error message if ESP isn't found #73

pikrzysztof opened this issue Oct 30, 2021 · 2 comments

Comments

@pikrzysztof
Copy link

pikrzysztof commented Oct 30, 2021

I installed system76-firmware and wanted to use the cli:

 # system76-firmware-cli
system76-firmware: EFI mount point not found
 # system76-firmware-cli -h
system76-firmware: EFI mount point not found

But i have my ESP mounted!

# findmnt /boot/esp
TARGET    SOURCE         FSTYPE OPTIONS
/boot/esp /dev/nvme0n1p1 vfat   rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,utf8,errors=remount-ro
# ls /boot/esp
 EFI   efibootmgr  'System Volume Information'

In order to get the software working I had to strace the program, learn where does it look for ESP mount and symlink the expected path to the actual mountpoint.

Can you please make the error message more informative and make it not require ESP mounts for --help flag?

We can also provide it with --efi-mount flag which allows the user to specify where to look for ESP.

@jacobgkau
Copy link
Member

system76-firmware attempts to get the ESP from bootctl before it tries any hard-coded paths:

pub fn get_efi_mnt() -> Option<String> {

What is the output of bootctl --print-esp-path on your system? Are you using Pop!_OS, or using system76-firmware on another distribution?

@pikrzysztof
Copy link
Author

I'm using system76-firmware on my ArchLinux installation.

I ran bootctl --print-esp-path and learned it cannot detect my ESP. I fixed my mountpoints to work well with bootctl and now system76-firmware works OK. Thank you for your help.

Relying on bootctl is prefectly reasonable but please disclose it in error message.

@jacobgkau jacobgkau changed the title firmware CLI won't start without esp mounted in a special place Mention bootctl in error message if ESP isn't found Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants