Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Test Case output in Objective-C #438

Open
ShauryaAg opened this issue Jan 2, 2021 · 3 comments
Open

Wrong Test Case output in Objective-C #438

ShauryaAg opened this issue Jan 2, 2021 · 3 comments
Assignees
Labels

Comments

@ShauryaAg
Copy link

Describe the bug
Objective-C unit test case Resolve URL (Quotes + Special Characters) Copy has output wherein it parse %26 as %2526. %26 is clearly a URL encoded & symbol, and hence it should be left as it is.

To Reproduce
Steps to reproduce the behavior:
Run npm test objective-c

Expected code snippet and corresponding request
%26 is a URL encoded & symbol, and hence it should be left as it is.

Screenshots
image

Additional context
%26 and %2526 are two different URLs. %25 should only be used if the URL contains a % sign, not when its parsing an already URL encoded string.

Version of postman-code-generators/Postman app:
Issue present in the commit: 31dc9f64295ec47b56c2912901eb39e5bdf067db

@ShauryaAg
Copy link
Author

Some unit test also do not URL encode ' (single-quotes character). ' character needs to be changed to %27 too

@umeshp7 umeshp7 assigned umeshp7 and webholik and unassigned umeshp7 Jan 4, 2021
@ShauryaAg
Copy link
Author

@umeshp7 I have already made a PR #437 that corrects this issue.

@umeshp7
Copy link
Contributor

umeshp7 commented Jan 4, 2021

@ShauryaAg Yes! Thanks for reporting the issue and the contribution.
We are assigning someone from the team also so that this is reviewed and merged soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants