Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

New Release to support ember engines. #145

Open
rakesh5208 opened this issue Sep 14, 2020 · 3 comments
Open

New Release to support ember engines. #145

rakesh5208 opened this issue Sep 14, 2020 · 3 comments

Comments

@rakesh5208
Copy link

code fix has been merged to master to support ember engines, new release is required to support the ember engines.
Existing release has bug, Router service is wrongly injected.

@GCheung55
Copy link

GCheung55 commented Sep 23, 2020

@dguettler anything we can help with to get a new release and should #146 be merged before a new release?

Edit Note: Updated because the wrong issue was referenced.

@rakesh5208
Copy link
Author

@GCheung55 , there is a bug, while using the ember engines, link-to component has been extended inside the ember-engines addon, that prefix the mountPoint inside the extended component.
So there is one PR #146 has been created, i think before release this bug has to fixed.

@GCheung55
Copy link

@rakesh5208 Sorry, I linked to the wrong PR in my comment but corrected it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants