Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Screen scaling: Gameplay" cuts off approach circles #26878

Closed
Qunas101 opened this issue Jan 31, 2024 · 8 comments
Closed

"Screen scaling: Gameplay" cuts off approach circles #26878

Qunas101 opened this issue Jan 31, 2024 · 8 comments

Comments

@Qunas101
Copy link

Type

Game behaviour

Bug description

If you set Screen scaling to Gameplay, you would see approach circles getting cut of at the edges. This is very distracting during gameplay and turns this option unusable. It's the only option that does not affect other menus and keeps map bg full screen.

I'm not sure about balancing, maybe that's a separate discussion, but how it looks currently is very wrong imo

I also saw this discussion and it seems to be a similar issue

Screenshots or videos

osu_2024-01-31_10-41-59

Version

2024.130.2

Logs

compressed-logs.zip

@bdach
Copy link
Collaborator

bdach commented Jan 31, 2024

I'm not sure about balancing, maybe that's a separate discussion, but how it looks currently is very wrong imo

The balancing is the point. You would have an advantage if approach circles weren't cut off.

@Qunas101
Copy link
Author

I understand that, but you can still play around with horizontal/vertical scaling and essentially trade vertical cutting off with horizontal, depending on the map perhaps. Is it not a balancing concern?

For example:

osu_2024-01-31_11-14-05 osu_2024-01-31_11-13-51
Default settings More vertical space with less horizontal to stay at the same size

@bdach
Copy link
Collaborator

bdach commented Jan 31, 2024

I'm not sure what those last screenshots are showing. Can you describe in more detail?

@frenzibyte
Copy link
Member

I'm just going to mark this as a duplicate of #5353, no need for another thread.

@frenzibyte frenzibyte closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
@Qunas101
Copy link
Author

My bad. Do I still describe it or just move on?

@bdach
Copy link
Collaborator

bdach commented Jan 31, 2024

@Qunas101 please do because if the clipping can be somehow bypassed somewhere else then we may need to actually introduce it there too

@Qunas101
Copy link
Author

It's not completely bypassed, you are "trading" vertical slicing for horizontal

So what I did was increase vertical scaling to it's max and decrease horizontal scaling until the playfield overall stays at a desired scale.
This results in no approach circles getting cut off at the top and bottom of the map, but instead they will get cut off at the sides of the map. So if a map has a few hit circles near the side edges, the impact will be minimal. The reverse logic applies

@Qunas101
Copy link
Author

Personally, I don't think seeing full approach circles is that beneficial, but you probably know more than me. I'm just reporting my observations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants