Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Edit externally" button in the editor is in English regardless of the selected language. #30567

Closed
MrCatGitHub opened this issue Nov 9, 2024 · 1 comment

Comments

@MrCatGitHub
Copy link

Type

Cosmetic

Bug description

In the editor, the "Edit externally" button is in English rather than the language osu! is set to.

Screenshots or videos

german
japanese

Version

2024.1009.1-lazer

Logs

compressed-logs.zip

@Joehuu
Copy link
Member

Joehuu commented Nov 9, 2024

There are many other strings hardcoded/unlocalisable, like the right side of editor, and that it's not strictly enforced for new strings, so closing for those reasons.

If you want, you can follow https://github.com/ppy/osu/wiki/Localising-the-client#localising-hardcoded-strings and make a pull request for the specified string you mentioned and possibly more that you can find.

As for a hint, I would put that string and other editor strings in https://github.com/ppy/osu/blob/master/osu.Game/Localisation/EditorStrings.cs.

@Joehuu Joehuu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants