Implement pagination for rankings overlay #31189
Open
+123
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31036.
Fully functional but may need to polish the way we implement this because I'm not sure adding the pagination in the Header is the way we want this, waiting for some reviews.
I've tried to visually replicate the website implementation, apart that we only show one page selector (on top) instead of two (bottom and top) as I think having both is kinda useless and we should just choose if we put it on top or bottom of the table.
About the available pages, as we can't fetch the potential total that the API would fetch, we put it to 200 available pages (like in the web version).
This PR also change the way the
TestRankingsOverlay
is loaded for tests Set-up to better start from a clean instance on each test.CleanShot.2024-12-19.at.01.45.35.mp4