Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for new song select "osu!" button #28147

Closed
wants to merge 6 commits into from

Remove outdated todo

f712afb
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Add implementation for new song select "osu!" button #28147

Remove outdated todo
f712afb
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed May 11, 2024 in 0s

5785 passed, 3 failed and 52 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

5840 tests were completed in 1428s with 5785 passed, 3 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.SongSelect.TestSceneSongSelectV2Navigation 1❌ 741ms
osu.Game.Tests.Visual.UserInterface.TestSceneModPresetColumn 8✅ 1❌ 11s
osu.Game.Tests.Visual.UserInterface.TestSceneShearedButtons 5✅ 1❌ 190ms

❌ osu.Game.Tests.Visual.SongSelect.TestSceneSongSelectV2Navigation

❌ TestConstructor
	System.InvalidOperationException : Sequence contains no elements

❌ osu.Game.Tests.Visual.UserInterface.TestSceneModPresetColumn

✅ TestAddingFlow(False)
✅ TestAddingFlow(True)
✅ TestBasicOperation
✅ TestConstructor
✅ TestDeleteFlow
❌ TestEditPresetMod
	"preset mod is changed" timed out
✅ TestEditPresetName
✅ TestSoftDeleteSupport
✅ TestTextFiltering

❌ osu.Game.Tests.Visual.UserInterface.TestSceneShearedButtons

✅ TestConstructor
✅ TestDisabledState
✅ TestShearedButton(False)
✅ TestShearedButton(True)
✅ TestShearedToggleButton
❌ TestSizing
	button is wider than text: Expected: greater than 199.919968f
	  But was:  30.0f

Annotations

Check failure on line 21 in osu.Game.Tests/Visual/SongSelect/TestSceneSongSelectV2Navigation.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.SongSelect.TestSceneSongSelectV2Navigation ► TestConstructor 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  System.InvalidOperationException : Sequence contains no elements
Raw output 
System.InvalidOperationException : Sequence contains no elements
   at System.Linq.ThrowHelper.ThrowNoElementsException()
   at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
   at osu.Game.Tests.Visual.SongSelect.TestSceneSongSelectV2Navigation.<SetUpSteps>b__0_2() in D:\a\osu\osu\osu.Game.Tests\Visual\SongSelect\TestSceneSongSelectV2Navigation.cs:line 21
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.UserInterface.TestSceneModPresetColumn ► TestEditPresetMod 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "preset mod is changed" timed out
Raw output 
"preset mod is changed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.UserInterface.TestSceneShearedButtons ► TestSizing 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  button is wider than text: Expected: greater than 199.919968f
    But was:  30.0f
Raw output 
button is wider than text: Expected: greater than 199.919968f
  But was:  30.0f

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.Run(Game game)
View more details on GitHub Actions