Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Don't try-include goalname as Makefile #515

Open
hanno-becker opened this issue Dec 12, 2024 · 0 comments
Open

Makefile: Don't try-include goalname as Makefile #515

hanno-becker opened this issue Dec 12, 2024 · 0 comments
Assignees
@potsrevennil

Comments

@hanno-becker
Copy link
Contributor

The current Makefile includes this line which interprets the goalname as a Makefile name and tries to import it.

-include mk/$(MAKECMDGOALS).mk

In my case, this led to a build failure because I still had an old acvp.mk lying around which then got triggered by make avcp -- a valid target!.

Task: Rewrite the Makefile so that we specifically include what we need per goal, rather than try-including the goalname as a Makefile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@potsrevennil potsrevennil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@potsrevennil @hanno-becker