-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable announcement banner to be sticky #546
Comments
I would like to have this as well. I'm hoping to adopt Furo as the base theme for Pallets projects and Flask. We have a sticky banner when viewing old or dev docs, you can see an example here: https://flask.palletsprojects.com/en/2.2.x/views/#view-decorators. It's sticky so that no matter where a user is linked to in the docs, they see the banner with a link to the current docs. I wrote some JavaScript to prevent it from overlapping headers when linking to an anchor as well as when clicking anchors on the page: https://github.com/pallets/pallets-sphinx-themes/blob/529e8fc362d99f600057fe78ffbe24a11f442276/src/pallets_sphinx_themes/themes/pocoo/static/version_warning_offset.js. It works on large and small screen sizes. I tried using Furo's announcement for this, but when I tried to make it sticky I ran into a few different problems:
|
FYI this is the CSS we needed to add a sticky top nav bar to qiskit_sphinx_theme, which builds off of Furo: HTML change: We use these visual regression tests from Playwright to make sure we aren't breaking things. That is, these are the edge cases we found that a sticky top element breaks: And indeed, gumshoe.js is broken for detecting the current section in the right side bar. But we're hoping that @pradyunsg will be okay with merging #664, which would fix the problem. |
What's happening?
Currently, I use the announcement banner to warn users that they are looking at an outdated version of the generated docs.
However, the banner is not sticky / fixed, so it disappears when users scroll down the page. This can be problematic when users access the docs through a hyperlink referencing a paragraph, as they probably won't see the banner.
I tried using custom CSS to simply make the banner sticky, but it seems it seems more complex (see discussion #545).
In particular, the rest of the page will scroll under the banner, eventually hiding the logo, which I think is not the expected behaviour.
Reproducer
Simply use
announcement
option and scroll down.Expectation
In my opinion, banners should be sticky by default in order to prevent this, but I guess having an option to make them sticky or not could be nice! 🙂
Code of Conduct
The text was updated successfully, but these errors were encountered: