Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs example confusion report] Dark vs. light image examples shouldn't look the same #836

Open
pradyunsg opened this issue Sep 3, 2024 Discussed in #835 · 1 comment
Labels
good first issue Good for newcomers

Comments

@pradyunsg
Copy link
Owner

Discussed in #835

Originally posted by webknjaz September 3, 2024
I was just showing https://pradyunsg.me/furo/reference/images/#different-images-for-dark-light-mode to a tech writer and wanted to demonstrate that toggling the mode at the top of that web page changes images.
I was expecting that the difference would be visible, but the images looked the same.
It took a minute to figure out the confusion — the image URLs are the same and the image is not different in any of the variants of this example.

I propose switching the example image to be different for dark vs. light modes. And additionally, it'd be good to use different images for image vs. figure.

@pradyunsg pradyunsg added the good first issue Good for newcomers label Sep 3, 2024
@pradyunsg
Copy link
Owner Author

A PR fixing this would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant