Github code owners

[brushmate]

Type of issue

Feature Request

Description

We at Yieldlab would like to review pull requests to our adapter as part of our development process and thought that it would be nice to utilize Github's code owners feature in order to request reviews from us. Is this something you would want to set up or is there any other option to get involved into the review process?

Other information

This topic has been brought up in 2018 in #3006 already, but unfortunately stale-bot closed this issue.

[dgirardi]

I was unaware of that feature and to me it seems like a great way to track module maintainers - something we are currently not great at. I don't think it will hurt if you want to start by suggesting a CODEOWNERS file with just your team in a PR. Going forward we'd probably want to make that part of the module submission process. @patmmccann what do you think?

[patmmccann]

This is awesome!

[brushmate]

I wanted to create a pull request, but unfortunately Github says that my CODEOWNERS file is invalid. It seems like the teams must come from the same organization that owns the repository. Thus I can not add a team from our organization :(

I guess you would have to manage teams for all the adapter maintainers in your Github organization. Additionally these teams need write access to the repository. I don't know how fine-grained you can configure the access rights, but it sounds like a lot of configuration that has to be done, especially if more companies want to maintain their adapter.

What do you think about it? Would this be viable?

[patmmccann]

We're unfamiliar with this; we'll investigate

[dgirardi]

The feature does not seem to behave according to its docs - even individual contributors do not validate ("make sure user exists and has write access").

IMO if it requires managing teams / collaborators within the Prebid org that's way too much overhead - I'd rather replicate the documented functionality separately with github actions or similar (i.e., have a file assigning github handles to file paths and some trigger that automatically notifies them of relevant PRs).

[patmmccann]

Further review indicates we can't give write access to a single file or folder and code owners must have write access; this is unfortunate, closing as infeasible.

[patmmccann]

A proposal has emerged for tech partners and above to be codeowners on their tests file. I think this is very reasonable.

[patmmccann]

We're leaning towards doing something a bit more ambitious, to tag people in pr's on their files in guthub automatically via a github action without giving write access. This would require a comment or some sort of metadata about who is who.

[patmmccann]

related: prebid/prebid-server#4075