Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom prebidMobilePluginRenderer support #1067

Open
jangirtony2009 opened this issue Nov 28, 2024 · 0 comments
Open

Custom prebidMobilePluginRenderer support #1067

jangirtony2009 opened this issue Nov 28, 2024 · 0 comments

Comments

@jangirtony2009
Copy link

Describe the bug
The current renderer design in the Prebid SDK faces the following challenges:

  1. OS does not seem to support sending custom data in the bid request. However, the following method exists:
    private PluginRenderer map(PrebidMobilePluginRenderer prebidMobilePluginRenderer) { PluginRenderer pluginRenderer = new PluginRenderer(); pluginRenderer.setName(prebidMobilePluginRenderer.getName()); pluginRenderer.setVersion(prebidMobilePluginRenderer.getVersion()); pluginRenderer.setData(prebidMobilePluginRenderer.getData()); return pluginRenderer; }
  2. Is there a way to leverage this or another method to enable sending custom data in iOS bid requests?
    iOS appears to lack support for interstitial ads in the Prebid custom renderer. Are there plans to introduce this functionality, or is there a recommended approach for adding interstitial ad support?
    The current issue with interstitials lies in the InterstitialController. Specifically:
    The variable adViewManager (var adViewManager: PBMAdViewManager?) needs to be made public. Alternatively, should the PBMAdViewDelegate be implemented and honored by the custom renderer?
    Additionally, there is no way to receive a callback for showInterstitialAd in the customAdapter.Could you clarify or suggest the best approach to address these challenges?
  3. The renderer maintains only a single object, which causes conflicts when multiple banner or interstitial objects are created, leading to overwriting.
  4. The existing PrebidMobilePluginRenderer is not aligned with the complete implementation of the interstitial. It has no support for the show, isReady.

To Reproduce
Steps to reproduce the behavior:
Try to create a new CustomRendere

Expected behavior

  1. Create CustomRenderer.
  2. Make a adRequest. The get data object is not getting called.
  3. when it call the CustomRenderer for interstitial. There is no way to pass the delegate.

Please take a look into the doc.

~557058afcfd484c4054dca9577f63850333f87-Proposed Design Document- Renderer Changes for Prebid SDK-281124-063952.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

2 participants