Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for logging Outbound Bidder Request #3157

Open
ghost opened this issue Apr 30, 2024 · 4 comments
Open

Support for logging Outbound Bidder Request #3157

ghost opened this issue Apr 30, 2024 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 30, 2024

Problem:
Http interaction Logger supports logging of bidder request before the changes are made by the corresponding request hooks and when the request is sent to the bidder. This creates the gap for logging the final bid request after if any changes are made by any adapter.

Proposed Solution:
Expose a function from from the http interaction logger class that logs the final request object (similar to HttpInteractionLogger.java maybeLogBidderRequest: https://github.com/prebid/prebid-server-java/blob/42c5b41d5d9d075ecb793936680b2c4f4be305f5/src/main/java/org/prebid/server/log/HttpInteractionLogger.java#L82C17-L82C38).

The client to call this function can be placed in HttpBidderRequester.java (

). Stream over each http request and log the body of the final request that has been created by the adapter.

@ghost
Copy link
Author

ghost commented May 21, 2024

@bretg if the proposed solution seems acceptable, shall I pick up the implementation?

@bretg
Copy link
Collaborator

bretg commented May 21, 2024

@b-chinmay - we don't fully understand what you're proposing. Is it that you essentially want to kick the system into debug mode when the http-interaction condition is met?

e.g. add a new flag to

https://prebid-server.example.com/logging/httpinteraction?limit=100&endpoint=auction&account=1111&debug=true

When debug=true is on the query string, the system could treat matched requests as if they had specified ext.prebid.debug:true, at least in the logs. This way we'd get not only the outbound requests but also the resolved request.

Ideally, this wouldn't affect the actual bid response.

@ghost
Copy link
Author

ghost commented May 21, 2024

@bretg that sounds about right.

@bretg
Copy link
Collaborator

bretg commented May 21, 2024

Cool. Then we'd be happy to accept a pull request. Thanks.

@bretg bretg removed their assignment May 21, 2024
@bretg bretg moved this from Clarify Request to Ready for Dev in Prebid Server Prioritization May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Dev
Development

No branches or pull requests

1 participant