Pubmatic: Bidder Updates #3652
Open
Pubmatic: Bidder Updates #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 24, 2024
CTMBNara
requested changes
Dec 27, 2024
Comment on lines
+133
to
+155
| private Pair<String, String> extractDisplayManagerFields(BidRequest request) { | ||
| final Optional<ExtApp> optionalExtApp = Optional.ofNullable(request.getApp()) | ||
| .map(App::getExt); | ||
|
|
||
| return optionalExtApp.map(ExtApp::getPrebid) | ||
| .filter(extAppPrebid -> StringUtils.isNoneBlank(extAppPrebid.getSource(), extAppPrebid.getVersion())) | ||
| .map(extAppPrebid -> Pair.of(extAppPrebid.getSource(), extAppPrebid.getVersion())) | ||
| .or(() -> optionalExtApp | ||
| .filter(extApp -> StringUtils.isNoneBlank( | ||
| getPropertyValue(extApp, "source"), | ||
| getPropertyValue(extApp, "version"))) | ||
| .map(extApp -> Pair.of( | ||
| extApp.getProperty("source").asText(), | ||
| extApp.getProperty("version").asText()))) | ||
| .orElse(Pair.of(null, null)); | ||
| } | ||
|
|
||
| private static String getPropertyValue(FlexibleExtension flexibleExtension, String propertyName) { | ||
| return Optional.ofNullable(flexibleExtension.getProperty(propertyName)) | ||
| .filter(JsonNode::isValueNode) | ||
| .map(JsonNode::asText) | ||
| .orElse(null); | ||
| } |
There was a problem hiding this comment.
This sims to ugly for me XD
What about this approach?
private Pair<String, String> extractDisplayManagerFields(App app) {
String source;
String version;
final ExtApp extApp = app != null ? app.getExt() : null;
final ExtAppPrebid extAppPrebid = extApp != null ? extApp.getPrebid() : null;
source = extAppPrebid != null ? extAppPrebid.getSource() : null;
version = extAppPrebid != null ? extAppPrebid.getVersion() : null;
if (StringUtils.isNoneBlank(source, version)) {
return Pair.of(source, version);
}
source = getPropertyValue(extApp, "source");
version = getPropertyValue(extApp, "version");
return StringUtils.isNoneBlank(source, version)
? Pair.of(source, version)
: Pair.of(null, null);
}
private static String getPropertyValue(FlexibleExtension flexibleExtension, String propertyName) {
return Optional.ofNullable(flexibleExtension)
.map(ext -> ext.getProperty(propertyName))
.filter(JsonNode::isValueNode)
.map(JsonNode::asText)
.orElse(null);
}
There was a problem hiding this comment.
Also, please, place methods in call order.
Comment on lines
+234
to
+239
| .displaymanager(StringUtils.isBlank(imp.getDisplaymanager()) | ||
| ? displayManager | ||
| : imp.getDisplaymanager()) | ||
| .displaymanagerver(StringUtils.isBlank(imp.getDisplaymanagerver()) | ||
| ? displayManagerVersion | ||
| : imp.getDisplaymanagerver()) |
There was a problem hiding this comment.
.displaymanager(StringUtils.firstNonBlank(imp.getDisplaymanager(), displayManager))
.displaymanagerver(StringUtils.firstNonBlank(imp.getDisplaymanagerver(), displayManagerVersion))
Comment on lines
+476
to
+482
| final ExtRequest extRequestWithoutPrebid = extRequest != null | ||
| ? mapper.fillExtension(ExtRequest.empty(), extRequest.getProperties()) | ||
| : ExtRequest.empty(); | ||
|
|
||
| return extNode.isEmpty() | ||
| ? extRequest | ||
| : mapper.fillExtension(extRequest == null ? ExtRequest.empty() : extRequest, extNode); | ||
| ? extRequestWithoutPrebid | ||
| : mapper.fillExtension(extRequestWithoutPrebid, extNode); |
There was a problem hiding this comment.
If you wanna duplicate logic from GO:
final ExtRequest newExtRequest = ExtRequest.empty();
return extNode.isEmpty()
? newExtRequest
: mapper.fillExtension(newExtRequest, extNode);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check