Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: adapter specific gpp-supported config-field is not getting honoured even though adapter dont have gpp-supported config set in the host specific pbs.yaml file #3177

Closed
ashishshinde-pubm opened this issue Oct 5, 2023 · 1 comment

Comments

@ashishshinde-pubm
Copy link
Contributor

ashishshinde-pubm commented Oct 5, 2023

Currently as per the code gpp-supported is supported only if adapter has entry in the host specific pbs.yaml
Current code does not honour the gpp-supported flag set in the adapter specific yaml file (bidder-info/adapter.yaml).
This is because we have missed to copy the values in applyBidderInfoConfigOverrides function.

Example -
pbs.yaml (host file) has following entry for pubmatic adapter

adapters:
  pubmatic:
    endpoint: https://hbopenbid.pubmatic.com/translator?source=prebid-server
 

bidder-info/pubmatic.yaml is like below

endpoint: "https://hbopenbid.pubmatic.com/translator?source=prebid-server"
maintainer:
  email: "[email protected]"
  ...
  ...
openrtb:
  gpp-supported: true

In above case, prebid will not honour the gpp-supported config field.
PR - #3178 fix this issue

@bretg
Copy link
Contributor

bretg commented Nov 3, 2023

Closing the issue as resolved with PR - #3178

@bretg bretg closed this as completed Nov 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Prebid Server Prioritization Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants