Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this line ever result in returning {}? #360

Open
VictorioBerra opened this issue Sep 27, 2017 · 0 comments
Open

Will this line ever result in returning {}? #360

VictorioBerra opened this issue Sep 27, 2017 · 0 comments

Comments

@VictorioBerra
Copy link

VictorioBerra commented Sep 27, 2017

https://github.com/preboot/angular-webpack/blob/51c72e481eecdaa461b8c3a1f021d2f2064e4b80/webpack.config.js#L44:L49

  if (!isTest) {
    config.entry = isTest ? {} : {

We only get this far if !isTest === true. With that logic, config.entry will never be an empty object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant