This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Approving then commenting does not dismiss approval #131
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This has been a TODO but i finally had a realy PR where this was meaningful
conan-center-index-pending-review/pending_review/review.go
Lines 99 to 102 in 4c0cb97
conan-io/conan-center-index#14703
[ { "id": 1215615204, "node_id": "PRR_kwDODDMJAM5IdNDk", "user": { "login": "uilianries", "id": 4870173, "node_id": "MDQ6VXNlcjQ4NzAxNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/uilianries", "html_url": "https://github.com/uilianries", "followers_url": "https://api.github.com/users/uilianries/followers", "following_url": "https://api.github.com/users/uilianries/following{/other_user}", "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}", "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions", "organizations_url": "https://api.github.com/users/uilianries/orgs", "repos_url": "https://api.github.com/users/uilianries/repos", "events_url": "https://api.github.com/users/uilianries/events{/privacy}", "received_events_url": "https://api.github.com/users/uilianries/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215615204", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "MEMBER", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215615204" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2022-12-13T14:42:11Z", "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1" }, { "id": 1215616053, "node_id": "PRR_kwDODDMJAM5IdNQ1", "user": { "login": "uilianries", "id": 4870173, "node_id": "MDQ6VXNlcjQ4NzAxNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/uilianries", "html_url": "https://github.com/uilianries", "followers_url": "https://api.github.com/users/uilianries/followers", "following_url": "https://api.github.com/users/uilianries/following{/other_user}", "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}", "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions", "organizations_url": "https://api.github.com/users/uilianries/orgs", "repos_url": "https://api.github.com/users/uilianries/repos", "events_url": "https://api.github.com/users/uilianries/events{/privacy}", "received_events_url": "https://api.github.com/users/uilianries/received_events", "type": "User", "site_admin": false }, "body": "Thank you for your contribution. I see you are using Conan in your project already 😸 ", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215616053", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "MEMBER", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215616053" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2022-12-13T14:50:39Z", "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1" }, { "id": 1221749995, "node_id": "PRR_kwDODDMJAM5I0mzr", "user": { "login": "bennyhuo", "id": 6336960, "node_id": "MDQ6VXNlcjYzMzY5NjA=", "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/bennyhuo", "html_url": "https://github.com/bennyhuo", "followers_url": "https://api.github.com/users/bennyhuo/followers", "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}", "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}", "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions", "organizations_url": "https://api.github.com/users/bennyhuo/orgs", "repos_url": "https://api.github.com/users/bennyhuo/repos", "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}", "received_events_url": "https://api.github.com/users/bennyhuo/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221749995", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "NONE", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221749995" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2022-12-17T08:03:52Z", "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1" }, { "id": 1221750124, "node_id": "PRR_kwDODDMJAM5I0m1s", "user": { "login": "bennyhuo", "id": 6336960, "node_id": "MDQ6VXNlcjYzMzY5NjA=", "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/bennyhuo", "html_url": "https://github.com/bennyhuo", "followers_url": "https://api.github.com/users/bennyhuo/followers", "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}", "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}", "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions", "organizations_url": "https://api.github.com/users/bennyhuo/orgs", "repos_url": "https://api.github.com/users/bennyhuo/repos", "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}", "received_events_url": "https://api.github.com/users/bennyhuo/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221750124", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "NONE", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221750124" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2022-12-17T08:05:35Z", "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1" }, { "id": 1221754527, "node_id": "PRR_kwDODDMJAM5I0n6f", "user": { "login": "bennyhuo", "id": 6336960, "node_id": "MDQ6VXNlcjYzMzY5NjA=", "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/bennyhuo", "html_url": "https://github.com/bennyhuo", "followers_url": "https://api.github.com/users/bennyhuo/followers", "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}", "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}", "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions", "organizations_url": "https://api.github.com/users/bennyhuo/orgs", "repos_url": "https://api.github.com/users/bennyhuo/repos", "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}", "received_events_url": "https://api.github.com/users/bennyhuo/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221754527", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "NONE", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221754527" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2022-12-17T08:29:08Z", "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1" }, { "id": 1263503119, "node_id": "PRR_kwDODDMJAM5LT4cP", "user": { "login": "uilianries", "id": 4870173, "node_id": "MDQ6VXNlcjQ4NzAxNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4", "gravatar_id": "", "url": "https://api.github.com/users/uilianries", "html_url": "https://github.com/uilianries", "followers_url": "https://api.github.com/users/uilianries/followers", "following_url": "https://api.github.com/users/uilianries/following{/other_user}", "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}", "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions", "organizations_url": "https://api.github.com/users/uilianries/orgs", "repos_url": "https://api.github.com/users/uilianries/repos", "events_url": "https://api.github.com/users/uilianries/events{/privacy}", "received_events_url": "https://api.github.com/users/uilianries/received_events", "type": "User", "site_admin": false }, "body": "@bennyhuo Thank you for your contribution! Please, take a look on my review", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1263503119", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "MEMBER", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1263503119" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-01-20T12:46:25Z", "commit_id": "bb2e1c54324fc12dee422af1b81c2cc1dabfbdc5" }, { "id": 1376580934, "node_id": "PRR_kwDODDMJAM5SDPVG", "user": { "login": "prince-chrismc", "id": 16867443, "node_id": "MDQ6VXNlcjE2ODY3NDQz", "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4", "gravatar_id": "", "url": "https://api.github.com/users/prince-chrismc", "html_url": "https://github.com/prince-chrismc", "followers_url": "https://api.github.com/users/prince-chrismc/followers", "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}", "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}", "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions", "organizations_url": "https://api.github.com/users/prince-chrismc/orgs", "repos_url": "https://api.github.com/users/prince-chrismc/repos", "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}", "received_events_url": "https://api.github.com/users/prince-chrismc/received_events", "type": "User", "site_admin": false }, "body": "Overall looks good, since this has been open for a while (sorry about that) there's more updates I'd like to sneak in", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376580934", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "CONTRIBUTOR", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376580934" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-04-07T21:07:57Z", "commit_id": "6b173fd061c77e5eb51990f372d9c138f14bd7fa" }, { "id": 1376588362, "node_id": "PRR_kwDODDMJAM5SDRJK", "user": { "login": "prince-chrismc", "id": 16867443, "node_id": "MDQ6VXNlcjE2ODY3NDQz", "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4", "gravatar_id": "", "url": "https://api.github.com/users/prince-chrismc", "html_url": "https://github.com/prince-chrismc", "followers_url": "https://api.github.com/users/prince-chrismc/followers", "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}", "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}", "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions", "organizations_url": "https://api.github.com/users/prince-chrismc/orgs", "repos_url": "https://api.github.com/users/prince-chrismc/repos", "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}", "received_events_url": "https://api.github.com/users/prince-chrismc/received_events", "type": "User", "site_admin": false }, "body": "I have some concerns about this project, since it's a fork we usually do not allow those\r\n\r\nand when they add enough value we ask for teh author prefix... but when I was looking into I noticed this has a copy of \r\n\r\nhttps://github.com/tinycthread/tinycthread\r\n\r\nembeeded inside ... which is fine but for conan that would ideal be a dependency since people could want to use two lirbaries that depend on it this and something else that would hit linkage issues.\r\n\r\nHave you considered linking against this library instead of copying it?\r\n\r\nhttps://github.com/mbrossard/threadpool/compare/master...bennyhuo:tinycthreadpool:master#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376588362", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "CONTRIBUTOR", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376588362" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-04-07T21:13:24Z", "commit_id": "6b173fd061c77e5eb51990f372d9c138f14bd7fa" }, { "id": 1387342546, "node_id": "PRR_kwDODDMJAM5SsSrS", "user": { "login": "prince-chrismc", "id": 16867443, "node_id": "MDQ6VXNlcjE2ODY3NDQz", "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4", "gravatar_id": "", "url": "https://api.github.com/users/prince-chrismc", "html_url": "https://github.com/prince-chrismc", "followers_url": "https://api.github.com/users/prince-chrismc/followers", "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}", "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}", "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions", "organizations_url": "https://api.github.com/users/prince-chrismc/orgs", "repos_url": "https://api.github.com/users/prince-chrismc/repos", "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}", "received_events_url": "https://api.github.com/users/prince-chrismc/received_events", "type": "User", "site_admin": false }, "body": "", "state": "APPROVED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387342546", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "CONTRIBUTOR", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387342546" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-04-17T06:20:36Z", "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364" }, { "id": 1387393721, "node_id": "PRR_kwDODDMJAM5SsfK5", "user": { "login": "prince-chrismc", "id": 16867443, "node_id": "MDQ6VXNlcjE2ODY3NDQz", "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4", "gravatar_id": "", "url": "https://api.github.com/users/prince-chrismc", "html_url": "https://github.com/prince-chrismc", "followers_url": "https://api.github.com/users/prince-chrismc/followers", "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}", "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}", "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions", "organizations_url": "https://api.github.com/users/prince-chrismc/orgs", "repos_url": "https://api.github.com/users/prince-chrismc/repos", "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}", "received_events_url": "https://api.github.com/users/prince-chrismc/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387393721", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "CONTRIBUTOR", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387393721" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-04-17T07:03:01Z", "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364" }, { "id": 1387394336, "node_id": "PRR_kwDODDMJAM5SsfUg", "user": { "login": "prince-chrismc", "id": 16867443, "node_id": "MDQ6VXNlcjE2ODY3NDQz", "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4", "gravatar_id": "", "url": "https://api.github.com/users/prince-chrismc", "html_url": "https://github.com/prince-chrismc", "followers_url": "https://api.github.com/users/prince-chrismc/followers", "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}", "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}", "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions", "organizations_url": "https://api.github.com/users/prince-chrismc/orgs", "repos_url": "https://api.github.com/users/prince-chrismc/repos", "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}", "received_events_url": "https://api.github.com/users/prince-chrismc/received_events", "type": "User", "site_admin": false }, "body": "", "state": "COMMENTED", "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387394336", "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703", "author_association": "CONTRIBUTOR", "_links": { "html": { "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387394336" }, "pull_request": { "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703" } }, "submitted_at": "2023-04-17T07:03:32Z", "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364" } ]The text was updated successfully, but these errors were encountered: