Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Reviewer is both a blocker and an approver according to the table. #4

Closed
prince-chrismc opened this issue Dec 29, 2020 · 2 comments
Closed

Comments

@prince-chrismc
Copy link
Owner

For 3427 uilianries is both a blocker and an approver according to the table. I guess you do not correctly overwrite the old reviews if a new one exists from the same user

Originally posted by @Croydon in #1 (comment)

Moving bug

@prince-chrismc prince-chrismc changed the title Reviewer is both a blocker and an approver according to the table. I guess you do not correctly overwrite the old reviews if a new one exists from the same user Reviewer is both a blocker and an approver according to the table. Dec 29, 2020
@prince-chrismc
Copy link
Owner Author

I guess you do not correctly overwrite the old reviews if a new one exists from the same user

That is exactly correct,

  • still learning golang and I have not found an easy way to reduce the array/slice.
  • There is pagination so not all the reviews come up on the first page, making it a little cumbersome

@prince-chrismc
Copy link
Owner Author

This issue how now been fixed with 884003b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant