Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor probnum.linalg to resolve the pylint messages #158

Closed
nathanaelbosch opened this issue Aug 19, 2020 · 1 comment
Closed

Refactor probnum.linalg to resolve the pylint messages #158

nathanaelbosch opened this issue Aug 19, 2020 · 1 comment
Labels
linalg Issues related to linear algebra refactoring Refactoring of existing functionality

Comments

@nathanaelbosch
Copy link
Collaborator

nathanaelbosch commented Aug 19, 2020

At the time of writing, probnum.linalg triggers the following pylint messages:

  • attribute-defined-outside-init
  • too-many-statements
  • too-many-instance-attributes
  • too-complex
  • protected-access
  • too-many-lines
  • no-self-use
  • too-many-locals
  • redefined-builtin
  • arguments-differ
  • abstract-method
  • too-many-arguments
  • too-many-branches
  • duplicate-code
  • unused-argument
  • fixme
  • missing-module-docstring

Goal:
Our long-term goal is to enable all of these checks for all parts of the project. Therefore, we should continuously work on fixing these. Currently, pylint is set up to have different checks for different modules, such that we can work on these problems individually and progress more quickly :)

To work on this issue you can check for these messages individually by calling:

pylint src/probnum/linalg --disable=all --enable=<message>

Then, after fixing all errors/warnings, you should remove the exception from the corresponding line in ./tox.ini, such that this message will be tracked in the future.

@marvinpfoertner
Copy link
Collaborator

Superseded by #523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linalg Issues related to linear algebra refactoring Refactoring of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants