Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release APKs lack versionCode #401

Open
IzzySoft opened this issue Jul 10, 2019 · 5 comments · May be fixed by #402
Open

Release APKs lack versionCode #401

IzzySoft opened this issue Jul 10, 2019 · 5 comments · May be fixed by #402
Assignees
@schuyler
Labels
bug A defect in design or behaviour

Comments

@IzzySoft
Copy link

I've just downloaded the APK from the last release, and it lacks the value for versionCode:

package: name='org.projectbuendia.client.dev' versionCode='' versionName='7af6a39' platformBuildVersionName='7af6a39'

As versionCode is what Android uses to tell versions apart (and to decide which is newer), this is an important technical detail. Could you please ensure it is set? And while on it, the commit hash is a bad idea for versionName – which is intended to be human-readable, so humans can tell versions apart; especially for non-techies it is hard to tell which hash is newer, so while on it, could you "sync" that with the tag name?

Thanks in advance!
@IzzySoft IzzySoft added the bug A defect in design or behaviour label Jul 10, 2019
@schuyler
Copy link
Member

The absence of versionCode should be fixed by #393, which will be incorporated in the next release. I'll have a look at adding a versionName also.

@schuyler schuyler self-assigned this Jul 10, 2019
@schuyler
Copy link
Member

Linking to the Android manifest docs for my own future reference

@IzzySoft
Copy link
Author

Thanks a lot! I'll check again when you give me a ping here (you'll probably want to close this when solved, which should fall closely together with the tag that has it solved).

@schuyler schuyler linked a pull request Jul 11, 2019 that will close this issue
Open
@zestyping
Copy link
Contributor

Our intention is for the versionName to be a commit hash for dev builds and a readable number for release builds.

@IzzySoft
Copy link
Author

Ah, OK – but the build I refered to was a release build (or should have been), having the "green badge" instead of the red pre-release one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schuyler schuyler

Labels
bug A defect in design or behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version numbering to dev builds projectbuendia/client
3 participants
@schuyler @zestyping @IzzySoft