Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Main class name change. #1

Open
frankdejonge opened this issue Jul 24, 2018 · 1 comment
Open

[Discussion] Main class name change. #1

frankdejonge opened this issue Jul 24, 2018 · 1 comment

Comments

@frankdejonge
Copy link

Since this only the first release in the 0.1 range, it might still be a good time to consider renaming this class. Event something like VaultlibClient would make it easier for IDE's and would prevent having to import-alias them. Especially since the "space" where this tool is used is already polluted with all kinds of Client classes.

@enygma
Copy link
Member

enygma commented Jul 24, 2018

You don't think it being in the Psecio\Vaultlib namespace is enough separation? I get where you're coming from but I'm not a huge fan of including the name of the library in the class names. I'd rather them be named for what they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants