You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But on posts that have external embeds such as twitter tweet embeds, github code embeds, instagram embeds and possible others, the code from the post breaks the page rendering because the script tag will be closed sooner that was suppose to, causing a HTML dump after the commenting box.
Steps to reproduce:
Create a new post
Paste the embed code of an instagram photo
Insert some text after the embed code
Publish it
Expected behavior
The blog post content is displayed once and then the comment box.
Actual behavior
The blog post content is displayed once then the comment box, then a markdown dump of everything after the closing script tag is presented in the page.
The text was updated successfully, but these errors were encountered:
fczuardi
added a commit
to fczuardi/nodebb-plugin-blog-comments
that referenced
this issue
Feb 14, 2016
The code appears to only target the id, I think the script tag was just the shortest way of making sure the content inside didn't appear. You can use another element and hide it specifically with css. Although good point it's probably a good idea if the markdown content should be embedded another way.
On the readme file installation instructions the code contains this:
But on posts that have external embeds such as twitter tweet embeds, github code embeds, instagram embeds and possible others, the code from the post breaks the page rendering because the script tag will be closed sooner that was suppose to, causing a HTML dump after the commenting box.
Steps to reproduce:
Expected behavior
The blog post content is displayed once and then the comment box.
Actual behavior
The blog post content is displayed once then the comment box, then a markdown dump of everything after the closing script tag is presented in the page.
The text was updated successfully, but these errors were encountered: