Move gulp build script to a ui5 CLI module

[fuchsvomwalde]

All settings used in package.json should be usable as CLI params, too.

Furthermore, the user should be able to decide, wether or not to use CLI params, package.json or a .ui5rc file.

[vvthinh]

I have viewed your project. OpenUser5 library you https://openui5.hana.ondemand.com/downloads/openui5-sdk-1.50.8.zip. This project has disadvantages if offline, do not use the library You can add the bundl library feature to openui5 for faster web applications. thank you!. If you do not bundle the openui5 library, the number of requests will greatly slow down the web app.thank you!

[vvthinh]

You can add the bundle library openui5.I hope to get help from your team..thank you!

[fuchsvomwalde]

Hi vvthinh, as mentioned in the README, you can define any UI5 library as source, a self build bundle, a CDN link (as configured at the time) or a custom build of UI5. Please see part Configuration in the README. Hope this information is helping you. Kind regards, Jascha Jascha A. Quintern Hackerstolz e.V. – Co-Founder & Board Member startregion e.V. – Co-Founder & Board Member PulseShift GmbH – Co-Founder & CXO Mobile: +49 1577 3819880 Twitter: @fuchsvomwalde Instagram: fuchsvomwalde Mailto: [email protected] Homepage: www.jascha-quintern.de Find me on Facebook, XING & LinkedIn

…

Am 26.03.2018 um 19:07 schrieb vvthinh ***@***.***>: You can add the bundle library openui5.I hope to get help from your team..thank you! — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AITaU4LhEh9LnsUdMMW0ERHLwwIgu4t7ks5tiSBbgaJpZM4SbelW>.

[jean-vox]

Hi.
I implemented your project successfully using the CDN = https://openui5.hana.ondemand.com/1.54.5/resources/sap-ui-core.js

When I copy the same version to a local directory (projectRoot->ui5->1.54.5->resources) and changing the package.json to use "local" with:
"local": {
"url": "ui5/{{version}}/resources/sap-ui-core.js",
"version": "1.54.5",
"isPrebuild": true,
"isArchive": false
}
It all fails to start the application:

Uncaught Error: ui5loader-autoconfig.js: could not determine base URL. No known script tag and no configuration found!
at ui5loader-autoconfig-dbg.js:83
at ui5loader-autoconfig-dbg.js:395
index.html:61 Uncaught TypeError: sap.ui.getCore is not a function
at index.html:61

[fuchsvomwalde]

Hi Jean, thanks for your message. Unfortunately I’m not able to reproduce your issue. Here is what I did: 1. download runtime (copied URL from here https://openui5.org/download.html) with the following setup: But this step can also be done manually. What download URL have you used? 2. after successful download, I switched the ui5 src to the local folder (as you did): But after starting the app with yarn start I had no console errors or any 404s. At the time I have only two assumptions: We used different download links for the UI5 runtime, or your project is missing corrections from the master branch. You may could try to clone the project again from master to ensure the code and related dependencies are up to date. Hope this information was helpful for you at that time. Kind regards, Jascha

…

Am 30.05.2018 um 07:15 schrieb jean-vox ***@***.***>: Hi. I implemented your project successfully using the CDN = https://openui5.hana.ondemand.com/1.54.5/resources/sap-ui-core.js <https://openui5.hana.ondemand.com/1.54.5/resources/sap-ui-core.js> When I copy the same version to a local directory (projectRoot->ui5->1.54.5->resources) and changing the package.json to use "local" with: "local": { "url": "ui5/{{version}}/resources/sap-ui-core.js", "version": "1.54.5", "isPrebuild": true, "isArchive": false } It all fails to start the application: Uncaught Error: ui5loader-autoconfig.js: could not determine base URL. No known script tag and no configuration found! at ui5loader-autoconfig-dbg.js:83 at ui5loader-autoconfig-dbg.js:395 index.html:61 Uncaught TypeError: sap.ui.getCore is not a function at index.html:61 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AITaU51L3lUxv7ofaqtEyCOz3qqg9lWFks5t3ir6gaJpZM4SbelW>.

[jean-vox]

Hi Jascha.
Finally got to the source of the issue: Windows.
Running the build on windows replaces the / slash with \ slash causing relative paths to fail.

[fuchsvomwalde]

Ah, that's very disadvantageous, of course. I created a GitHub issue to track when relative paths in the ui5 configuration are also compatible on Windows.#27 <#27>

…

Am 12.06.2018 um 08:11 schrieb jean-vox ***@***.***>: Running the build on windows replaces the / slash with \ slash causing relative paths to fail.

[verfehlix]

Just ran into the same issue :-)

[fuchsvomwalde]

The solution will be to use path.normalize(sAnyRelativeOrAbsolutePath) anywhere in gulfile.babel.js where paths are used for execution, e.g. "readFile()". It will convert any path into the correct representation matching the respective OS the node script is running on.