Clean up disk space for coverage job #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Feb 28, 2024
| @@ -138,6 +138,11 @@ jobs: | |||
| needs: prerequisites | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Free Disk Space (Ubuntu) | |||
| uses: jlumbroso/free-disk-space@main | |||
There was a problem hiding this comment.
Can we pin the version here? I'm not wild about unpinned dependencies here.
Suggested change
| uses: jlumbroso/free-disk-space@main | |
| uses: jlumbroso/free-disk-space@v1.3.1 |
There was a problem hiding this comment.
mb, copied this from the repo, will pin it separately everywhere.
There was a problem hiding this comment.
It's all good. Thanks for quickly following up!
VenelinMartinov
added a commit
that referenced
this pull request
Feb 28, 2024
addresses the comment in #833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw some failures in AWS: https://github.com/pulumi/pulumi-aws/actions/runs/8076447038/job/22065470841
tested in https://github.com/pulumi/pulumi-aws/actions/runs/8079968659/job/22075523684?pr=3507