When there is a dash - in the instance name, the Postgresql_conf defined resource fails

[ianc769]

Describe the Bug

When there is a dash - in the instance name, the Postgresql_conf defined resource fails

profile::postgres::instances:
  "%{facts.networking.hostname}":
    instance_user: "postgres"
    instance_group: "postgres"

We want to build the instance based off the hostname, as in our environment its 1 server for 1 instance.

For example
Given:

root@TEST-PG-1234:[~]: puppet facts | grep hostname
    "hostname": "TEST-PG-1234",

Error:

Error: Failed to apply catalog: Parameter name failed on Postgresql_conf[authentication_timeout_TEST-PG-1234]: Invalid value "authentication_timeout_TEST-PG-1234". Valid values match /^[\w.]+$/.(file:/etc/puppetlabs/code/environments/dash_test/modules/postgresql/manifests/server/config_entry.pp, line: 89)

I think its related to this:

puppetlabs-postgresql/lib/puppet/type/postgresql_conf.rb

Line 9 in ab7e59e

newvalues(%r{^[\w.]+$})

Expected Behavior

Puppet should be okay with dashes in the resource name.

Steps to Reproduce

Steps to reproduce the behavior:
Build an instance with dashes in the name.

Environment

• Puppet 8.10.0
• Red Hat Enterprise Linux release 8.10 (Ootpa)